Skip to content

fix pointer issue for GCE staging support #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2024
Merged

fix pointer issue for GCE staging support #1609

merged 1 commit into from
Feb 17, 2024

Conversation

Sneha-at
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
It fixes the pointer related issue from PR#1586
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 16, 2024
@pwschuurman
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwschuurman, Sneha-at

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2024
@pwschuurman pwschuurman mentioned this pull request Feb 17, 2024
Merged
@k8s-ci-robot k8s-ci-robot merged commit 55091b9 into kubernetes-sigs:master Feb 17, 2024
@Sneha-at Sneha-at mentioned this pull request Feb 20, 2024
Merged
k8s-ci-robot added a commit that referenced this pull request Feb 20, 2024
@k8s-ci-robot
Merge pull request #1614 from Sneha-at/automated-cherry-pick-of-#1586-#…
52239f2 
…1609-upstream-release-1.13

Automated cherry pick of #1586: update driver to support staging compute
#1609: fix pointer issue for GCE staging support
amacaskill added a commit that referenced this pull request Feb 20, 2024
@amacaskill
Revert "Automated cherry pick of #1586: update driver to support stag…
38dd889 
…ing compute

#1609: fix pointer issue for GCE staging support"
k8s-ci-robot added a commit that referenced this pull request Feb 20, 2024
@k8s-ci-robot
Merge pull request #1615 from kubernetes-sigs/revert-1614-automated-c…
c60d05b 
…herry-pick-of-#1586-#1609-upstream-release-1.13

Revert "Automated cherry pick of #1586: update driver to support staging compute#1609: fix pointer issue for GCE staging support"
@Sneha-at Sneha-at mentioned this pull request Feb 20, 2024
Merged
k8s-ci-robot added a commit that referenced this pull request Feb 20, 2024
@k8s-ci-robot
Merge pull request #1617 from Sneha-at/automated-cherry-pick-of-#1586-#…
722430e 
…1609-upstream-release-1.13

Automated cherry pick of #1586: update driver to support staging compute
#1609: fix pointer issue for GCE staging support
@Sneha-at Sneha-at mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacaskill amacaskill Awaiting requested review from amacaskill

@leiyiz leiyiz Awaiting requested review from leiyiz

Assignees

@pwschuurman pwschuurman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sneha-at @pwschuurman @k8s-ci-robot